Skip to content

Add news for Dates - ISO year / ISO week utilities #59776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 13, 2025
Merged

Add news for Dates - ISO year / ISO week utilities #59776

merged 16 commits into from
Oct 13, 2025
+4 −0

Conversation

isentropic
Copy link
Contributor

No description provided.

isentropic and others added 16 commits February 9, 2023 15:26
@isentropic
add iso utils
fb513fb
@isentropic @knuesel
Update stdlib/Dates/src/accessors.jl
37a2e26 
Co-authored-by: Jeremie Knuesel <[email protected]>
@isentropic @knuesel
Update stdlib/Dates/src/accessors.jl
2ce2e36 
Co-authored-by: Jeremie Knuesel <[email protected]>
@isentropic @knuesel
Update stdlib/Dates/src/accessors.jl
c449892 
Co-authored-by: Jeremie Knuesel <[email protected]>
@isentropic
dt to year
05237f2
@isentropic
add tests and docs
1ab03e7
@isentropic
close doctest blocks
e1b856e
@isentropic @inkydragon
Update stdlib/Dates/src/accessors.jl
d6417ed 
Co-authored-by: woclass <[email protected]>
@isentropic @knuesel
Update stdlib/Dates/src/accessors.jl
2e48a3c 
Co-authored-by: Jeremie Knuesel <[email protected]>
@isentropic
Merge branch 'master' into master
63f7bc7
@ViralBShah
Merge branch 'master' into master
f10604e
@adienes
Merge branch 'master' into master
b119ace
@isentropic
docs: add compat string
0285827
@adienes
Merge branch 'master' into master
b3525f0
@isentropic
Merge branch 'JuliaLang:master' into master
17baf0c
@isentropic
docs: update news
684e7fa
@isentropic isentropic mentioned this pull request Oct 8, 2025
Merged
@ViralBShah ViralBShah changed the title Followup from https://github.com/JuliaLang/julia/pull/48507 (add news for Dates) Add news for Dates - ISO year / ISO week utilities Oct 13, 2025
@ViralBShah ViralBShah merged commit 1a8c862 into JuliaLang:master Oct 13, 2025
5 of 9 checks passed
@KristofferC
Copy link
Member

This didn't pass CI and seems to have broken the build?


┌ Error: invalid local link/image: file does not exist in src/NEWS.md
--
  | │   link =
  | │    @ast MarkdownAST.Link("ISO week date", "") do
  | │      MarkdownAST.Text("https://en.wikipedia.org/wiki/ISO")
  | │      MarkdownAST.Emph() do
  | │        MarkdownAST.Text("week")
  | │      end
  | │      MarkdownAST.Text("date")
  | │    end
  | │
  | └ @ Documenter /cache/build/builder-amdci4-4/julialang/julia-master/deps/jlutilities/depot/packages/Documenter/iRt2s/src/utilities/utilities.jl:47
  | [ Info: CheckDocument: running document checks.
  | [ Info: Populate: populating indices.
  | ERROR: LoadError: `makedocs` encountered an error [:cross_references] -- terminating build before rendering.
  | Stacktrace:

KristofferC added a commit that referenced this pull request Oct 14, 2025
@KristofferC
Revert "Add news for Dates - ISO year / ISO week utilities (#59776)"
d9e3e71 
This reverts commit 1a8c862.
@KristofferC KristofferC mentioned this pull request Oct 14, 2025
Merged
@KristofferC
Copy link
Member

I've reverted this

@isentropic
Copy link
Contributor Author

Is there anything to do on my end? (im the author of #48507)

@isentropic
Copy link
Contributor Author

This is probably because I ddint format the wiki link correctly right? How should I have done it?

@KristofferC
Copy link
Member

See https://anvilproject.org/guides/content/creating-links.

Also

`isoweekdate, isoyear, weeksinyear`

should be

`isoweekdate`, isoyear`, `weeksinyear`

@ViralBShah
Copy link
Member

CI was green when I merged it IIRC.

@adienes adienes added the reverted This PR has since been reverted label Oct 14, 2025
@KristofferC
Copy link
Member

KristofferC commented Oct 14, 2025 •
edited
Loading

https://buildkite.com/julialang/julia-master/builds/51206#_ is what the last CI shows for me before it was merged and it also has a red cross.

image

But, easily fixed so 🤷

@isentropic isentropic mentioned this pull request Oct 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vtjnash vtjnash

Labels

reverted This PR has since been reverted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@isentropic @KristofferC @ViralBShah @vtjnash @adienes